[vlc-commits] Missing poll() declaration

[Pierre Ynard]

vlc | branch: master | R?mi Denis-Courmont <remi at remlab.net> | Tue
Jan 24 17:51:12 2012 +0200| [b0623ca0851e47b8d2d7110c4d54c03b69751149] |
committer: R?mi Denis-Courmont
Missing poll() declaration

http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b0623ca0851e47b8d2d7110c4d54c03b69751149

We still have:

make[7]: Entering directory `/home/buildslave/slave/i386-win32/build/build/modules/gui/qt4'
CXX adapters/libqt4_plugin_la-seekpoints.moc.lo
In file included from ../../../../extras/package/win32/../../../include/vlc_common.h:481,
from adapters/../../../../../modules/gui/qt4/adapters/seekpoints.hpp:25,
from adapters/seekpoints.moc.cpp:10:
../../../../extras/package/win32/../../../include/vlc_threads.h: In function 'int vlc_poll(pollfd*, unsigned int, int)':
../../../../extras/package/win32/../../../include/vlc_threads.h:406: error: 'poll' was not declared in this scope
../../../../extras/package/win32/../../../include/vlc_threads.h:413: error: 'poll' was not declared in this scope
make[7]: *** [adapters/libqt4_plugin_la-seekpoints.moc.lo] Error 1

Somehow config.h is not included, so there is no poll() declaration. The
same problem will come up with out-of-tree modules, since they don't
have a config.h. I don't really see how to fix this, but maybe an #error
at least would be nice.

Regards,

[Rémi Denis-Courmont]

On Wed, 25 Jan 2012 05:12:50 +0100, Pierre Ynard <linkfanel at yahoo.fr>

Post by Pierre Ynard
Somehow config.h is not included,

Yeah well that's a separate and older bug, and I will not fix it (because
I do not build Qt4 on Windows).